Skip to content

container: fix error release#1933

Merged
giuseppe merged 1 commit intocontainers:mainfrom
eriksjolund:fix-error-release
Dec 18, 2025
Merged

container: fix error release#1933
giuseppe merged 1 commit intocontainers:mainfrom
eriksjolund:fix-error-release

Conversation

@eriksjolund
Copy link
Contributor

@eriksjolund eriksjolund commented Dec 17, 2025 •
edited by sourcery-ai bot
Loading

Summary by Sourcery

Bug Fixes:

  • Release the error object prior to returning from container delete status handling to avoid leaking error state.

@eriksjolund
container: fix error release
2805abd 
Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
@sourcery-ai
Copy link

sourcery-ai bot commented Dec 17, 2025 •
edited
Loading

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Ensure container deletion path correctly releases the main error object before delegating to libcrun_container_delete_status, avoiding an error leak in the non-OCI-state-root branch.

File-Level Changes

Change Details Files
Release the primary error object before returning container delete status to prevent leaking the error in the non-OCI-state-root deletion path.
  • Add a crun_error_release call on the main err object after handling the tmp_err early-return case
  • Preserve existing behavior of libcrun_container_delete_status call and return value semantics
 src/libcrun/container.c

Possibly linked issues

  • #krun runtime causing SIGSEGV since commit 379524f: PR fixes missing error release in container deletion, likely addressing the SIGSEGV regression introduced by commit 379524f.
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot approved these changes Dec 17, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The new crun_error_release(err); appears to free err before it is passed to libcrun_container_delete_status(state_root, id, err), which risks a use-after-free; consider either moving the release after the call or adjusting libcrun_container_delete_status usage so you are not passing a released error object.
Prompt for AI Agents 
Please address the comments from this code review:

## Overall Comments
- The new `crun_error_release(err);` appears to free `err` before it is passed to `libcrun_container_delete_status(state_root, id, err)`, which risks a use-after-free; consider either moving the release after the call or adjusting `libcrun_container_delete_status` usage so you are not passing a released error object.
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@packit-as-a-service
Copy link

packit-as-a-service bot commented Dec 17, 2025

TMT tests failed. @containers/packit-build please check.

giuseppe
giuseppe approved these changes Dec 18, 2025
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe merged commit ff35788 into containers:main Dec 18, 2025
41 of 44 checks passed
@eriksjolund eriksjolund deleted the fix-error-release branch January 14, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giuseppe giuseppe giuseppe approved these changes

+1 more reviewer

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eriksjolund @giuseppe